[PATCH] D50993: [clangd] Increase stack size of the new threads on macOS

Dmitry via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 21 06:11:11 PDT 2018


Dmitry.Kozhevnikov added a comment.

In https://reviews.llvm.org/D50993#1207357, @ilya-biryukov wrote:

> 1. Can we put the helper that executes the tasks asynchronously with a stack size into llvm's threading library (i.e. somewhere close to `llvm::execute_on_thread`?) All platform-specific code is already there, we can reuse most of the implementation too.


Do you think it would be OK to have pthreads-only version there, with `std::thread` fallback on Windows? I'd like to avoid writing a Windows-only implementation myself, as it's a bit alien for me.

> 2. I wonder if we should expose the stack size as an option to clangd?

Do you expect it would be ever used?


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50993





More information about the cfe-commits mailing list