[PATCH] D50926: [SourceManager] Extract 'findFileIDsForFile' from 'translateFile' to allow mapping from one file entry to multiple FileIDs

[Eric Liu via Phabricator via cfe-commits]

ioeric added inline comments.


================
Comment at: lib/Basic/SourceManager.cpp:1705
 
   // If we haven't found what we want yet, try again, but this time stat()
   // each of the files in case the files have changed since we originally
----------------
Do we also need this in `findFileIDsForFile`?


================
Comment at: unittests/Basic/SourceManagerTest.cpp:380
 
+TEST_F(SourceManagerTest, findFileIDsForFile) {
+  const char *header = "int x;";
----------------
Could you add a test case for getting file ID for main file, just to make sure we also covered cases handled by `if (MainFileID.isValid()) {...}`  code path in `translateFile()`?


Repository:
  rC Clang

https://reviews.llvm.org/D50926