[PATCH] D50994: Add a new flag and attributes to control static destructor registration

Erik Pilkington via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 20 15:42:09 PDT 2018


erik.pilkington updated this revision to Diff 161594.
erik.pilkington marked 7 inline comments as done.
erik.pilkington added a comment.

In this new patch:

- Fix some grammar errors in the documentation.
- Add a testcase for both attributes appearing on a variable.
- Just use hasArg() in the driver.
- Improve the diagnostic.

Thanks for the feedback!


https://reviews.llvm.org/D50994

Files:
  clang/include/clang/AST/Decl.h
  clang/include/clang/Basic/Attr.td
  clang/include/clang/Basic/AttrDocs.td
  clang/include/clang/Basic/DiagnosticSemaKinds.td
  clang/include/clang/Basic/LangOptions.def
  clang/include/clang/Driver/Options.td
  clang/lib/AST/Decl.cpp
  clang/lib/CodeGen/ItaniumCXXABI.cpp
  clang/lib/CodeGen/MicrosoftCXXABI.cpp
  clang/lib/Driver/ToolChains/Clang.cpp
  clang/lib/Frontend/CompilerInvocation.cpp
  clang/lib/Sema/SemaDeclAttr.cpp
  clang/lib/Sema/SemaDeclCXX.cpp
  clang/test/CodeGenCXX/always_destroy.cpp
  clang/test/CodeGenCXX/no_destroy.cpp
  clang/test/Misc/pragma-attribute-supported-attributes-list.test
  clang/test/SemaCXX/no_destroy.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50994.161594.patch
Type: text/x-patch
Size: 14681 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180820/1c42c7d4/attachment-0001.bin>


More information about the cfe-commits mailing list