[PATCH] D50962: [clangd] Speculative code completion index request before Sema is run.

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 20 08:26:47 PDT 2018


ioeric planned changes to this revision.
ioeric added a comment.

I just realized that `CodeCompleteFlow` would be blocked by the speculative index request even when index request is not needed (e.g. member access), because it owns the future object. This can make some completion requests slower. We may need to move the async index query into the `ClangdServer::codeComplete` so that completion callback can be invoked as soon as results are ready, without having to wait for speculative index results.

F7000668: future-redundant-wait.png <https://reviews.llvm.org/F7000668>


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50962





More information about the cfe-commits mailing list