[PATCH] D50956: [clangd] NFC: Cleanup Dex Iterator comments and simplify tests

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 20 01:19:37 PDT 2018


kbobyrev created this revision.
kbobyrev added a reviewer: ioeric.
Herald added subscribers: kadircet, arphaman, omtcyfz, jkorous, MaskRay, ilya-biryukov.

Proposed changes:

- Cleanup comments in `clangd/index/dex/Iterator.h`: Vim's `gq` formatting added redundant spaces instead of newlines in few places
- Few comments in `OrIterator` are wrong
- Use `EXPECT_TRUE(Condition)` instead of `EXPECT_THAT(Condition, true)` (same with `EXPECT_FALSE`)

This patch does not affect functionality.


https://reviews.llvm.org/D50956

Files:
  clang-tools-extra/clangd/index/dex/Iterator.cpp
  clang-tools-extra/clangd/index/dex/Iterator.h
  clang-tools-extra/unittests/clangd/DexIndexTests.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50956.161431.patch
Type: text/x-patch
Size: 7080 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180820/8eda9a78/attachment.bin>


More information about the cfe-commits mailing list