[PATCH] D50740: [SourceManager] isPointWithin: avoid using isBeforeInTranslationUnit, compare buffer offsets directly for lexical correctness

Alex Lorenz via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 17 14:18:53 PDT 2018


arphaman added a comment.

Hmm, after more analysis I realized that this is not the right solution for the rename problem. It would be correct to map one file:line:column location to a set of `SourceLocation`s, and to use the old `isPointWithin` on a set of such locations. I opened https://reviews.llvm.org/D50926 instead. Sorry for the trouble!


Repository:
  rC Clang

https://reviews.llvm.org/D50740





More information about the cfe-commits mailing list