[PATCH] D50877: [MS] Mangle a hash of the main file path into anonymous namespaces

Reid Kleckner via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 17 13:53:06 PDT 2018


rnk added a comment.

In https://reviews.llvm.org/D50877#1204609, @thakis wrote:

> Can you explicitly mention that this intentionally doesn't use an absolute path in MicrosoftMangleContextImpl() or similar?


Sure. I also described the issue with codeview that motivates why we want unique names.

I think I sent this out hastily at the end of the day yesterday, and I didn't write enough comments to answer all of your questions. Hopefully with these changes it makes more sense.


https://reviews.llvm.org/D50877





More information about the cfe-commits mailing list