[PATCH] D50488: [Analyzer] Checker for non-determinism caused by sorting of pointer-like keys

Mandeep Singh Grang via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 17 13:13:26 PDT 2018


mgrang added a comment.

In https://reviews.llvm.org/D50488#1203876, @Szelethus wrote:

> I think testcases for non-class iterator objects would be valuable.


Thanks @Szelethus. Yes, as you correctly pointed out this would not match non-class iterator objects.

This is my first time with ASTMatchers and I am not sure how to get the value_type from hasType (I don't see a matcher for value_types in ASTMatchers.h). Would I end up using a visitor for that? If yes, then maybe the entire check for pointer types needs to be done via visitors? Sorry for the newbie questions :)


https://reviews.llvm.org/D50488





More information about the cfe-commits mailing list