[PATCH] D50877: [MS] Mangle a hash of the main file path into anonymous namespaces

Bob Haarman via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 16 17:48:27 PDT 2018


inglorion added inline comments.


================
Comment at: clang/lib/AST/MicrosoftMangle.cpp:389
+  if (FE) {
+    llvm::MD5 Hasher;
+    llvm::MD5::MD5Result Hash;
----------------
Instead of MD5, can we use xxhash (or whatever the fastest hash algorithm in LLVM is these days)? I don't think we need a particular hash algorithm, so we might as well go with the fastest one we have (as long as it does a good job avoiding collisions, of course).


https://reviews.llvm.org/D50877





More information about the cfe-commits mailing list