[PATCH] D50616: [Fixed Point Arithmetic] FixedPointCast

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 16 16:25:15 PDT 2018


leonardchan added a comment.

In https://reviews.llvm.org/D50616#1202034, @ebevhan wrote:

> I think I've mentioned this before, but I would like to discuss the possibility of adding a target hook(s) for some of these operations (conversions, arithmetic when it comes). Precisely matching the emitted saturation operation is virtually impossible for a target.


Sorry I forgot to address this also. Just to make sure I understand this correctly since I haven't used these before: target hooks are essentially for emitting target specific code for some operations right? Does this mean that the `EmitFixedPointConversion` function should be moved to a virtual method under `TargetCodeGenInfo` that can be overridden and this is what get's called instead during conversion?


Repository:
  rC Clang

https://reviews.llvm.org/D50616





More information about the cfe-commits mailing list