[PATCH] D50740: [SourceManager] isPointWithin: avoid using isBeforeInTranslationUnit, compare buffer offsets directly for lexical correctness

[Alex Lorenz via Phabricator via cfe-commits]

arphaman marked 2 inline comments as done.
arphaman added inline comments.


================
Comment at: lib/Basic/SourceManager.cpp:2035
+         "Passed invalid source location!");
+  assert(Start.isFileID() && End.isFileID() && Loc.isFileID() &&
+         "Passed non-file source location!");
----------------
ioeric wrote:
> Why do we disallow locations from macro expansions?
I changed the patch to allow them by working with spelling locs.


Repository:
  rC Clang

https://reviews.llvm.org/D50740