[PATCH] D50870: Close FileEntries of cached files in ModuleManager::addModule().

Adrian Prantl via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 16 15:06:58 PDT 2018


aprantl added a comment.

@bruno: When we last discussed this my plan was to avoid the stat() in lookupModuleFile() for files that were just added to the PCMCache by WriteAST() entirely, but ModuleManager::Modules is a DenseMap<FileEntry, ModuleFile *> and lookupModuleFile() is the easiest way to create a new FileEntry. It would be nice to find a way to avoid the stat() for a file that we just wrote, but it wasn't immediately obvious to me how to do that.


Repository:
  rL LLVM

https://reviews.llvm.org/D50870





More information about the cfe-commits mailing list