[PATCH] D50852: abseil-auto-make-unique

Hugo Gonzalez via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 16 12:52:47 PDT 2018


hugoeg added a comment.

In https://reviews.llvm.org/D50852#1202774, @lebedev.ri wrote:

> 1. Please always upload all patches with full context.
> 2. There already is `modernize-use-auto`. Does it handle this case? Then this should be just an alias to that check. Else, i think it would be best to extend that one, and still alias.


since this check checks for absl::make_unique primarily 
if we move it to the general check, it'd be weird to check for absl::make_unique
right now our main goal is to release checks tailored specifically to abseil users, so if we can we would like to release this check separately in the abseil directory


https://reviews.llvm.org/D50852





More information about the cfe-commits mailing list