[PATCH] D50785: [clangd][tests] Add exit(EXIT_FAILURE) in case of JSON parsing failure in TestMode

[Jan Korous via Phabricator via cfe-commits]

jkorous added a comment.

Oh, I thought that what everyone wanted was test-specific behaviour. I like both approaches you propose much more!
If we go for the generic option we can effectively start "checking stderr" in tests by using the flag. That would be nice.

Just to be sure we are all on the same page:

1. Do we want to exit right after elog() call?
2. Do we consider calling exit() in elog() smart or hacky?

Based on quick grepping if we'd like to propagate errors probably the biggest challenge would be ASTWorker.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50785