[PATCH] D50739: Clean up macros to detect underling C library functionality

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 14 15:16:02 PDT 2018


ldionne added inline comments.


================
Comment at: include/__config:433
 
-#if __ISO_C_VISIBLE >= 2011 || __cplusplus >= 201103L
+#if __ISO_C_VISIBLE >= 2011
 #  if defined(__FreeBSD__)
----------------
ldionne wrote:
> mclow.lists wrote:
> > Should we be using `__ISO_C_VISIBLE` here, or `__STDC_VERSION__`?
> > I didn't change this, but ...
> The weird part is that neither is defined when compiling C++ code..
This means that `TEST_HAS_C11_FEATURES` and `_LIBCPP_HAS_C11_FEATURES` will both be disabled all the time.


https://reviews.llvm.org/D50739





More information about the cfe-commits mailing list