[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

[John McCall via Phabricator via cfe-commits]

rjmccall added a comment.

In https://reviews.llvm.org/D50630#1198053, @riccibruno wrote:

> I actually did exactly this. My approach was to extend what is already done,
>  that is add nested classes SomethingBitfields in Type and add an instance of
>  each to the anonymous union. The classes which I have found so far benefiting
>  from this are FunctionProtoType, TemplateSpecializationType, PackExpansionType,
>  DependentTemplateSpecializationType and SubstTemplateTypeParmPackType.
>
> For example the patch dealing with TemplateSpecializationType is
>  here https://reviews.llvm.org/D50643.


I see.  This is one of those rare cases where your changes probably would've been
clearer not broken up into multiple patches. :)  I only got CC'ed on two of them.

Anyway, I think we're all in agreement that this is the right thing to do now.

John.


Repository:
  rC Clang

https://reviews.llvm.org/D50630