[PATCH] D50630: [AST] Update/correct the static_asserts for the bit-fields in Type

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 13 12:23:41 PDT 2018


rjmccall added a comment.

Oh, I missed that there was a separate review for this.  A lot of the important subclasses that need extra storage have been designed with the expectation that these bit-fields fit within 32 bits.  For example, `FunctionType` starts with a bunch of bit-fields because the expectation is that they'll fit into the tail-padding of `Type`.  So this assertion should really be testing <= 4, and if we need to land a few patches first to make that true, we should do so.


Repository:
  rC Clang

https://reviews.llvm.org/D50630





More information about the cfe-commits mailing list