[PATCH] D50559: [gnu-objc] Make selector order deterministic.

[John McCall via Phabricator via cfe-commits]

rjmccall accepted this revision.
rjmccall added a comment.
This revision is now accepted and ready to land.

Thanks.  I appreciate the fact that you spelled it all out in the test, too.

LGTM.



================
Comment at: lib/CodeGen/CGObjCGNU.cpp:3547
+      allSelectors.push_back(entry.first);
+    llvm::sort(allSelectors.begin(), allSelectors.end());
 
----------------
theraven wrote:
> bmwiedemann wrote:
> > compilation failed here:
> > ../tools/clang/lib/CodeGen/CGObjCGNU.cpp:2444:11: error: 'sort' is not a member of 'llvm'
> > 
> > it suggested std::sort
> I'm not sure `llvm::sort` was part of the 6.0 release, it was added in April and so should be in 7.0.  I don't expect a patch against the 8 branch to apply cleanly to 6...
`array_pod_sort` has been around forever if we need a variant of the patch for that branch.


Repository:
  rC Clang

https://reviews.llvm.org/D50559