[PATCH] D50549: [libcxx] [test] Repair thread unsafety in thread tests
Billy Robert O'Neal III via Phabricator via cfe-commits
cfe-commits at lists.llvm.org
Mon Aug 13 10:39:00 PDT 2018
BillyONeal added inline comments.
================
Comment at: test/std/thread/thread.threads/thread.thread.class/thread.thread.member/detach.pass.cpp:75
assert(G::op_run);
assert(G::n_alive == 1);
}
----------------
Actually I just realized that this assert is bogus too; there's no synchronization to ensure the copied g is destroyed here.
https://reviews.llvm.org/D50549
More information about the cfe-commits
mailing list