[PATCH] D50559: [gnu-objc] Make selector order deterministic.

David Chisnall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 11 04:15:13 PDT 2018


theraven added inline comments.


================
Comment at: lib/CodeGen/CGObjCGNU.cpp:3547
+      allSelectors.push_back(entry.first);
+    llvm::sort(allSelectors.begin(), allSelectors.end());
 
----------------
bmwiedemann wrote:
> compilation failed here:
> ../tools/clang/lib/CodeGen/CGObjCGNU.cpp:2444:11: error: 'sort' is not a member of 'llvm'
> 
> it suggested std::sort
I'm not sure `llvm::sort` was part of the 6.0 release, it was added in April and so should be in 7.0.  I don't expect a patch against the 8 branch to apply cleanly to 6...


Repository:
  rC Clang

https://reviews.llvm.org/D50559





More information about the cfe-commits mailing list