[PATCH] D50580: [clang-tidy] Abseil: no namespace check

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sat Aug 11 03:44:21 PDT 2018


JonasToth added a comment.

Could it happen that some template specializations or so need to land in `absl`?



================
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:28
+void NoNamespaceCheck::check(const MatchFinder::MatchResult &Result) {
+  const auto *decl = Result.Nodes.getNodeAs<NamespaceDecl>("absl_namespace");
+
----------------
Please follow LLVM naming convention (Capitalize, and Decl should crash with a type)


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50580





More information about the cfe-commits mailing list