[PATCH] D50580: [clang-tidy] Abseil: no namespace check

[Eugene Zelenko via Phabricator via cfe-commits]

Eugene.Zelenko added a comment.

Check documentation is missing.



================
Comment at: clang-tidy/abseil/NoNamespaceCheck.cpp:21
+void NoNamespaceCheck::registerMatchers(MatchFinder *Finder) {
+  if (!getLangOpts().CPlusPlus) return;
+
----------------
Please place return in separate line.


================
Comment at: clang-tidy/abseil/NoNamespaceCheck.h:25
+class NoNamespaceCheck : public ClangTidyCheck {
+ public:
+  NoNamespaceCheck(StringRef Name, ClangTidyContext *Context)
----------------
Please run Clang-format.


================
Comment at: docs/ReleaseNotes.rst:60
 
 The improvements are...
 
----------------
Please remove placeholder.


================
Comment at: docs/ReleaseNotes.rst:65
+
+  Checks to ensure user did not open namespace absl as that
+  violates abseil's compatibility guidelines.
----------------
Please reformulate to refer to code, not user. Please enclose absl in ``.


================
Comment at: docs/ReleaseNotes.rst:66
+  Checks to ensure user did not open namespace absl as that
+  violates abseil's compatibility guidelines.
+
----------------
abseil ->Abseil.


https://reviews.llvm.org/D50580