[PATCH] D50517: [clangd] Generate incomplete trigrams for the Dex index

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 10 12:30:30 PDT 2018


ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lg! Thanks for the changes!



================
Comment at: clang-tools-extra/clangd/index/dex/Trigram.cpp:147
+      if (Chars.size() == 3) {
+        const auto Trigram =
+            Token(Token::Kind::Trigram, std::string(begin(Chars), end(Chars)));
----------------
nit: inline this variable? You don't need to `count` below as `insert` duplicates for you already.


https://reviews.llvm.org/D50517





More information about the cfe-commits mailing list