[PATCH] D46652: [clang-cl, PCH] Implement support for MS-style PCH through headers

[Nico Weber via Phabricator via cfe-commits]

thakis added a comment.

In https://reviews.llvm.org/D46652#1174220, @mikerice wrote:

> In https://reviews.llvm.org/D46652#1164010, @thakis wrote:
>
> > Also, were you planning on also adding support for the (filename-less version of) hdrstop pragma? After this change, that should probably be fairly straightforward.
>
>
> Thanks for taking a look.  I'll be going through our PCH tests at some point soon and will likely add support for this and any other interesting issues that remain.


Cool :-) I gave hrdstop a try (wip at https://reviews.llvm.org/D49496) but kind of got stuck and haven't had time to become unstuck. If you get to it first, maybe the wip patch is useful (or not).

It looks like your change did break using /P together with /Yu: https://bugs.llvm.org/show_bug.cgi?id=38508


Repository:
  rC Clang

https://reviews.llvm.org/D46652