[PATCH] D50557: [clang][mips] Set __mips_fpr correctly for -mfpxx

Stefan Maksimovic via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 10 04:15:17 PDT 2018


smaksimovic created this revision.
smaksimovic added a reviewer: atanasyan.
Herald added subscribers: arichardson, sdardis.

Set __mips_fpr to 0 if o32 ABI is used with either -mfpxx or none of -mfp32, -mfpxx, -mfp64 being specified.

Introduce additional checks:

- -mfpxx is only to be used in conjunction with the o32 ABI.
- report an error when incompatible options are provided.

Formerly no errors were raised when combining n32/n64 ABIs with -mfp32 and -mfpxx.

There are other cases when __mips_fpr should be set to 0 that are not covered, ex. using o32 on a mips64 cpu which is valid but not supported in the backend as of yet.


https://reviews.llvm.org/D50557

Files:
  include/clang/Basic/DiagnosticCommonKinds.td
  lib/Basic/Targets/Mips.cpp
  lib/Basic/Targets/Mips.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D50557.160085.patch
Type: text/x-patch
Size: 5022 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180810/7391503d/attachment.bin>


More information about the cfe-commits mailing list