[PATCH] D50449: [clangd] Support textEdit in addition to insertText.

Kadir Cetinkaya via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 10 02:22:53 PDT 2018


kadircet added inline comments.


================
Comment at: clangd/CodeComplete.cpp:1310
+  // other.
+  for (const auto &FixIt : FixIts) {
+    if (IsRangeConsecutive(FixIt.range, LSP.textEdit->range)) {
----------------
ilya-biryukov wrote:
> Maybe keep the `reserve` call? (we could reserve one extra element, but that's fine)
Actually we could have much more than one extra element, not for the current situation but may be in the future when we have more fixit completions.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50449





More information about the cfe-commits mailing list