[PATCH] D50539: [VFS] Add property 'fallthrough' that controls fallback to real file system.

Volodymyr Sapsai via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 9 16:05:35 PDT 2018


vsapsai added a comment.

Known issues:

- No support for 'fallthrough' in crash reproducer.
- Current way of working with modules in VFS "root" is clunky and error-prone.

Also I don't like that VFSFromYamlDirIterImpl is similar to overlay iterator but doesn't share code. At the moment I think it's not worth it to rework those abstractions to make more code reusable. If you've noticed problems with those iterators before, maybe it makes sense to try to find a better approach.


https://reviews.llvm.org/D50539





More information about the cfe-commits mailing list