[PATCH] D50534: [libc++] Fix handling of negated character classes in regex

Louis Dionne via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 9 14:14:04 PDT 2018


ldionne added a comment.

The changeset that introduced this regression was reviewed as https://reviews.llvm.org/D37955. @timshen, I'm curious to understand why you or'ed with `__neg_chars_.empty()` when initializing `__in_neg_chars`. The logic's not clear to me, and my tests seem to show that this is wrong, but I don't understand the reasoning behind doing it in the first place, so I might be introducing another bug here. Please double-check.


Repository:
  rCXX libc++

https://reviews.llvm.org/D50534





More information about the cfe-commits mailing list