[PATCH] D50415: [clangd] extend the publishDiagnostics response to send back fixits to the client directly as well (if requested)

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Aug 9 01:29:37 PDT 2018


ilya-biryukov added inline comments.


================
Comment at: clangd/ClangdLSPServer.cpp:441
                                  const clangd::CodeCompleteOptions &CCOpts,
+                                 const ClangdDiagnosticOptions &DiagOpts,
                                  llvm::Optional<Path> CompileCommandsDir,
----------------
Maybe remove this parameter now that we configure these via LSP?
We don't set it to anything other than the default anyway.


https://reviews.llvm.org/D50415





More information about the cfe-commits mailing list