[PATCH] D50154: [clangd] capitalize diagnostic messages

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 8 05:00:29 PDT 2018


ilya-biryukov added a comment.

In https://reviews.llvm.org/D50154#1191002, @dblaikie wrote:

> What's the motivation for clangd to differ from clang here?


The presentation of diagnostics to the users is different between clang and clangd:

- clang diagnostics are always prefixed with the file, location and severity of the diagnostic, e.g. `main.cpp:1:2: error: expected '}'`
- In LSP clients (VSCode in particular), the diagnostic message is the first thing the user sees and it looks a little nicer (subjectively) if the first letter is capitalized.

See the screenshots from VSCode on how diagnostics are presented:
F6901986: image.png <https://reviews.llvm.org/F6901986> F6901990: image.png <https://reviews.llvm.org/F6901990>


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D50154





More information about the cfe-commits mailing list