r339185 - Make test more robust by not checking hard coded debug info values, but instead check the relationships between them.

via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 7 14:29:34 PDT 2018



> -----Original Message-----
> From: cfe-commits [mailto:cfe-commits-bounces at lists.llvm.org] On Behalf Of
> Douglas Yung via cfe-commits
> Sent: Tuesday, August 07, 2018 5:23 PM
> To: cfe-commits at lists.llvm.org
> Subject: r339185 - Make test more robust by not checking hard coded debug
> info values, but instead check the relationships between them.
> 
> Author: dyung
> Date: Tue Aug  7 14:22:49 2018
> New Revision: 339185
> 
> URL: http://llvm.org/viewvc/llvm-project?rev=339185&view=rev
> Log:
> Make test more robust by not checking hard coded debug info values, but
> instead check the relationships between them.
> 
> Modified:
>     cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl
> 
> Modified: cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl
> URL: http://llvm.org/viewvc/llvm-
> project/cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-
> block.cl?rev=339185&r1=339184&r2=339185&view=diff
> ==========================================================================
> ====
> --- cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl
> (original)
> +++ cfe/trunk/test/CodeGenOpenCL/enqueue-kernel-non-entry-block.cl Tue Aug
> 7 14:22:49 2018
> @@ -16,7 +16,7 @@ kernel void test(int i) {
>  // SPIR64: %block_sizes = alloca [1 x i64]
>  // COMMON-LABEL: if.then:
>  // COMMON-NOT: alloca
> -// CHECK-DEBUG: getelementptr {{.*}} %block_sizes, {{.*}} !dbg !34
> +// CHECK-DEBUG: getelementptr {{.*}} %block_sizes, {{.*}} !dbg
> ![[TEMPLOCATION:[0-9]+]]
>  // COMMON-LABEL: if.end
>    queue_t default_queue;
>    unsigned flags = 0;
> @@ -27,5 +27,7 @@ kernel void test(int i) {
> 
>  // Check that the temporary is scoped to the `if`
> 
> -// CHECK-DEBUG: !32 = distinct !DILexicalBlock(scope: !7, file: !1, line:
> 24)
> -// CHECK-DEBUG: !34 = !DILocation(line: 25, scope: !32)
> +// CHECK-DEBUG: ![[TESTFILE:[0-9]+]] = !DIFile(filename: "<stdin>"
> +// CHECK-DEBUG: ![[TESTSCOPE:[0-9]+]] = distinct !DISubprogram(name:
> "test", {{.*}} file: ![[TESTFILE]]
> +// CHECK-DEBUG: ![[IFSCOPE:[0-9]+]] = distinct !DILexicalBlock(scope:
> ![[TESTSCOPE]], file: !1, line: 24)

You missed a hard-coded !1 here, should be [[TESTFILE]].

> +// CHECK-DEBUG: ![[TEMPLOCATION]] = !DILocation(line: 25, scope:
> ![[IFSCOPE]])
> 
> 
> _______________________________________________
> cfe-commits mailing list
> cfe-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/cfe-commits


More information about the cfe-commits mailing list