[PATCH] D50152: [CodeGen] Merge equivalent block copy/helper functions

John McCall via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Aug 7 11:19:28 PDT 2018


rjmccall added a comment.

That is a change that Richard should definitely sign off on.  Also, I'm not sure this works — is it really okay to skip the work done by `ResolveExceptionSpec` in IRGen?  What does that mean, that we're just somewhat more conservative than we would otherwise be?  And why is this a better solution than just storing whether the copy-expression throws in `BlockDecl::Capture`?


Repository:
  rC Clang

https://reviews.llvm.org/D50152





More information about the cfe-commits mailing list