[PATCH] D50099: [DebugInfo][OpenCL] Address post-commit review of D49930

[Scott Linder via Phabricator via cfe-commits]

scott.linder added inline comments.


================
Comment at: lib/CodeGen/CGDebugInfo.cpp:997
   llvm::DINode::DIFlags Flags = llvm::DINode::FlagAppleBlock;
   unsigned LineNo = 0;
 
----------------
echristo wrote:
> scott.linder wrote:
> > echristo wrote:
> > > Just noticed that LineNo is 0... for the entire function.
> > What should it be instead? My understanding is that LineNo=0 indicates there is no corresponding source, and these fields seem to be implementation details.
> Could probably just replace it with a constant 0 in the calls rather than having the local?
Oh, I see what you mean; I will make that change, and I am also working out how to enable ASan correctly to check the patch, then I will post a new diff.


https://reviews.llvm.org/D50099