[PATCH] D49945: [Fixed Point Arithmetic] Fix for FixedPointValueToString

Leonard Chan via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 6 08:53:19 PDT 2018


leonardchan marked an inline comment as done.
leonardchan added inline comments.


================
Comment at: lib/AST/Expr.cpp:788
   FixedPointValueToString(
-      S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale, Radix);
+      S, llvm::APSInt::getUnsigned(getValue().getZExtValue()), Scale);
   return S.str();
----------------
ebevhan wrote:
> Unrelated to this patch specifically, but using `getZExtValue` here is a bit limiting.
I'll make another small patch to change this since should also do signed values now,


Repository:
  rC Clang

https://reviews.llvm.org/D49945





More information about the cfe-commits mailing list