[PATCH] D50337: [clangd] DexIndex implementation prototype

Kirill Bobyrev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 6 08:19:43 PDT 2018


kbobyrev planned changes to this revision.
kbobyrev added a comment.

The patch is currently in preview-mode; I have to make few changes:

- Improve testing infrastructure; one possible way would be to use exactly the same code `MemIndex` currently does as it is meant to be a drop-in replacement. An existing obstacle would be not handling <3 long queries, but it's not hard to fix.
- Documenting `DexIndex` implementation and thinking about how to abstract out very similar code pieces shared with `MemIndex`. The proposed implementation is rather straightforward, but few pieces are identical to `MemIndex` which causes some code duplication.


https://reviews.llvm.org/D50337





More information about the cfe-commits mailing list