r338996 - [clang-rename] make clang-rename.py vim integration python3 compatible

Jonas Toth via cfe-commits cfe-commits at lists.llvm.org
Mon Aug 6 02:08:06 PDT 2018


Author: jonastoth
Date: Mon Aug  6 02:08:06 2018
New Revision: 338996

URL: http://llvm.org/viewvc/llvm-project?rev=338996&view=rev
Log:
[clang-rename] make clang-rename.py vim integration python3 compatible

Summary:
This patch makes the clang-rename.py script useable for vim with only python3
support. It uses the print-function and adjust the doc slightly to mention
the correct python3 command for the letter mapping in vim.

Reviewers: arphaman, klimek, aaron.ballman, hokein

Reviewed By: hokein

Subscribers: cfe-commits

Differential Revision: https://reviews.llvm.org/D50307

Modified:
    cfe/trunk/tools/clang-rename/clang-rename.py

Modified: cfe/trunk/tools/clang-rename/clang-rename.py
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/tools/clang-rename/clang-rename.py?rev=338996&r1=338995&r2=338996&view=diff
==============================================================================
--- cfe/trunk/tools/clang-rename/clang-rename.py (original)
+++ cfe/trunk/tools/clang-rename/clang-rename.py Mon Aug  6 02:08:06 2018
@@ -7,10 +7,14 @@ Before installing make sure one of the f
 * `g:clang_rename_path` in ~/.vimrc points to valid clang-rename executable
 * `binary` in clang-rename.py points to valid to clang-rename executable
 
-To install, simply put this into your ~/.vimrc
+To install, simply put this into your ~/.vimrc for python2 support
 
     noremap <leader>cr :pyf <path-to>/clang-rename.py<cr>
 
+For python3 use the following command (note the change from :pyf to :py3f)
+
+    noremap <leader>cr :py3f <path-to>/clang-rename.py<cr>
+
 IMPORTANT NOTE: Before running the tool, make sure you saved the file.
 
 All you have to do now is to place a cursor on a variable/function/class which
@@ -18,6 +22,7 @@ you would like to rename and press '<lea
 name if the cursor points to a valid symbol.
 '''
 
+from __future__ import print_function
 import vim
 import subprocess
 import sys
@@ -30,8 +35,8 @@ def main():
     # Get arguments for clang-rename binary.
     offset = int(vim.eval('line2byte(line("."))+col(".")')) - 2
     if offset < 0:
-        print >> sys.stderr, '''Couldn\'t determine cursor position.
-                                Is your file empty?'''
+        print('Couldn\'t determine cursor position. Is your file empty?',
+              file=sys.stderr)
         return
     filename = vim.current.buffer.name
 
@@ -51,7 +56,7 @@ def main():
     stdout, stderr = p.communicate()
 
     if stderr:
-        print stderr
+        print(stderr)
 
     # Reload all buffers in Vim.
     vim.command("checktime")




More information about the cfe-commits mailing list