[PATCH] D45444: [clang-tidy] implement new check for const-correctness

Jonas Toth via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Sun Aug 5 09:14:09 PDT 2018


JonasToth updated this revision to Diff 159224.
JonasToth added a comment.

- revert breaking change in LocalVar matcher.

Reverting the change from `allOf(...)` to `unless(anyOf(..))`. I did not investigate
the reason for it breaking, because basic logic suggests that transformation
should be correct.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D45444

Files:
  clang-tidy/cppcoreguidelines/CMakeLists.txt
  clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.cpp
  clang-tidy/cppcoreguidelines/ConstCorrectnessCheck.h
  clang-tidy/cppcoreguidelines/CppCoreGuidelinesTidyModule.cpp
  docs/clang-tidy/checks/cppcoreguidelines-const-correctness.rst
  docs/clang-tidy/checks/list.rst
  test/clang-tidy/cppcoreguidelines-const-correctness-pointer-as-values.cpp
  test/clang-tidy/cppcoreguidelines-const-correctness-values.cpp

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D45444.159224.patch
Type: text/x-patch
Size: 34381 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180805/686969b5/attachment-0001.bin>


More information about the cfe-commits mailing list