[PATCH] D50154: [clangd] capitalize diagnostic messages if '-capitialize-diagnostic-text' is provided

Eric Liu via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 11:25:18 PDT 2018


ioeric accepted this revision.
ioeric added a comment.
This revision is now accepted and ready to land.

lgtm



================
Comment at: clangd/Diagnostics.cpp:149
+/// Capitalizes the first word in the diagnostic's message.
+std::string capitalizeDiagnosticText(std::string Message) {
+  if (!Message.empty())
----------------
nit: this doesn't have to be diagnostic text, so I'd probably call this `capitalize()`.


https://reviews.llvm.org/D50154





More information about the cfe-commits mailing list