[PATCH] D50218: [OpenMP] Encode offload target triples into comdat key for offload initialization code

Sergey Dmitriev via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Fri Aug 3 10:52:36 PDT 2018


sdmitriev added inline comments.


================
Comment at: lib/CodeGen/CGOpenMPRuntime.cpp:3825
+    // this particular combination of offloading targets.
+    SmallVector<StringRef, 4U> RegFnNameParts;
+    RegFnNameParts.push_back("omp_offloading");
----------------
ABataev wrote:
> Preallocate the memory for all elements at construction, you know the number of elements.
Agree.


https://reviews.llvm.org/D50218





More information about the cfe-commits mailing list