[PATCH] D49511: [Sema/Attribute] Check for noderef attribute

[Aaron Ballman via Phabricator via cfe-commits]

aaron.ballman added inline comments.


================
Comment at: include/clang/Basic/AttrDocs.td:3489
+
+``noderef`` is currently only supported for C style pointers and arrays and not usable for
+references or Objective-C pointers.
----------------
I would drop the "C style" and just say it's only supported for pointers and arrays.


================
Comment at: include/clang/Basic/AttrDocs.td:3490
+``noderef`` is currently only supported for C style pointers and arrays and not usable for
+references or Objective-C pointers.
+
----------------
I'd clarify this a little bit to Objective-C object pointers.


================
Comment at: include/clang/Basic/DiagnosticSemaKinds.td:9436
+def warn_dereference_of_noderef_type : Warning<
+  "dereferencing %0; was declared with a `noderef` type">, InGroup<NoDeref>;
+def warn_dereference_of_noderef_type_no_decl : Warning<
----------------
Please use single quotes instead of backticks in the quoting around `noderef` in these diagnostics.


Repository:
  rC Clang

https://reviews.llvm.org/D49511