[clang-tools-extra] r338518 - [clangd] Receive compilationDatabasePath in 'initialize' request

Simon Marchi via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 1 11:27:53 PDT 2018


On 2018-08-01 01:30 PM, Alex L wrote:
> Is there a particular reason why this commit didn't have a corresponding test included?
> Cheers,
> Alex
Back when we made the corresponding change in "onChangeConfiguration", there was no
straightforward way to make a lit test for it:

https://reviews.llvm.org/D39571?id=124024#inline-359345

I am not sure, but I think the issue was that we had to hard-code the length of the
messages we sent.  Since we had to use temp directory names, the length was not
known in advance.  I don't think we have that limitation anymore.

We would need to create a temporary directory hierarchy, and then refer to it in
the messages we send to switch between build configurations.  Is it something that
sounds possible with lit?  Do you know about other tests doing something similar?

Thanks,

Simon


More information about the cfe-commits mailing list