[PATCH] D49223: [AST] Check described template at structural equivalence check.

Aleksei Sidorin via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 1 07:28:22 PDT 2018


a_sidorin added inline comments.


================
Comment at: lib/AST/ASTStructuralEquivalence.cpp:958
 
+  if (D1->isTemplated() != D2->isTemplated())
+    return false;
----------------
I think we can move the changes for both RecordDecl and FunctionDecl into `Finish()` and use `Decl::getDescribedTemplate()`. This will both simplify the patch and give us the support for templated VarDecls and TypeAliasDecls for free. What do you think?


Repository:
  rC Clang

https://reviews.llvm.org/D49223





More information about the cfe-commits mailing list