[PATCH] D49833: [clangd] Receive compilationDatabasePath in 'initialize' request

Ilya Biryukov via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Wed Aug 1 02:23:29 PDT 2018


ilya-biryukov accepted this revision.
ilya-biryukov added a comment.
This revision is now accepted and ready to land.

LGTM with a small nit. Thanks for the change!



================
Comment at: clangd/ClangdLSPServer.cpp:419
+    DidChangeConfigurationParams &Params) {
+  ClangdConfigurationParamsChange &Settings = Params.settings;
+  applyConfiguration(Settings);
----------------
NIT: replace with `applyConfiguration(Params.settings)` to get rid of the extra local var


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49833





More information about the cfe-commits mailing list