[PATCH] D47267: [UnrollAndJam] Add unroll_and_jam pragma handling

Michael Kruse via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Tue Jul 31 10:13:36 PDT 2018


Meinersbur accepted this revision.
Meinersbur added a comment.
This revision is now accepted and ready to land.

LGTM



================
Comment at: lib/Sema/SemaStmtAttr.cpp:183
                    {nullptr, nullptr}};
-
   for (const auto *I : Attrs) {
----------------
[nit] unrelated whitespace change?


================
Comment at: test/CodeGenCXX/pragma-unroll-and-jam.cpp:4
+void unroll_and_jam(int *List, int Length, int Value) {
+  // CHECK: define {{.*}} @_Z14unroll_and_jam
+#pragma unroll_and_jam
----------------
[suggestion] `CHECK-LABEL`? (applies to the function names below as well)


https://reviews.llvm.org/D47267





More information about the cfe-commits mailing list