[PATCH] D49953: [compiler-rt] Add a routine to specify the mode used when creating profile dirs.

Matt Davis via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Mon Jul 30 10:22:35 PDT 2018


mattd added a comment.

In https://reviews.llvm.org/D49953#1180466, @probinson wrote:

> Is it possible/reasonable for the test to call __llvm_profile_recursive_mkdir and then verify the mode of the created directory?
>  The test would have to be flagged as unsupported on Windows but that seems fine.


That't totally possible, as long as it's fine to call fstat()/stat() to gather the mode value on the resulting directory.   We'd also
need to get the umask() so that we can ensure that the correct value is set with respect to the user's umask.


https://reviews.llvm.org/D49953





More information about the cfe-commits mailing list