r338230 - PR38355 Prevent infinite recursion when checking initializer lifetime if

[Richard Smith via cfe-commits]

Author: rsmith
Date: Mon Jul 30 00:19:54 2018
New Revision: 338230

URL: http://llvm.org/viewvc/llvm-project?rev=338230&view=rev
Log:
PR38355 Prevent infinite recursion when checking initializer lifetime if
an initializer is self-referential.

Modified:
    cfe/trunk/lib/Sema/SemaInit.cpp
    cfe/trunk/test/SemaCXX/warn-dangling-local.cpp

Modified: cfe/trunk/lib/Sema/SemaInit.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/lib/Sema/SemaInit.cpp?rev=338230&r1=338229&r2=338230&view=diff
==============================================================================
--- cfe/trunk/lib/Sema/SemaInit.cpp (original)
+++ cfe/trunk/lib/Sema/SemaInit.cpp Mon Jul 30 00:19:54 2018
@@ -6570,7 +6570,8 @@ static void visitLocalsRetainedByInitial
           [&](IndirectLocalPath &Path, Local L, ReferenceKind RK) -> bool {
         if (auto *DRE = dyn_cast<DeclRefExpr>(L)) {
           auto *VD = dyn_cast<VarDecl>(DRE->getDecl());
-          if (VD && VD->getType().isConstQualified() && VD->getInit()) {
+          if (VD && VD->getType().isConstQualified() && VD->getInit() &&
+              !isVarOnPath(Path, VD)) {
             Path.push_back({IndirectLocalPathEntry::VarInit, DRE, VD});
             visitLocalsRetainedByInitializer(Path, VD->getInit(), Visit, true);
           }

Modified: cfe/trunk/test/SemaCXX/warn-dangling-local.cpp
URL: http://llvm.org/viewvc/llvm-project/cfe/trunk/test/SemaCXX/warn-dangling-local.cpp?rev=338230&r1=338229&r2=338230&view=diff
==============================================================================
--- cfe/trunk/test/SemaCXX/warn-dangling-local.cpp (original)
+++ cfe/trunk/test/SemaCXX/warn-dangling-local.cpp Mon Jul 30 00:19:54 2018
@@ -18,3 +18,9 @@ void f() {
   // points to, which doesn't live long enough.
   int *const &s = (int *const &)T{1, 2, 3}; // expected-warning {{temporary bound to local reference 's' will be destroyed at the end of the full-expression}}
 }
+
+// PR38355
+void g() {
+  const int a[] = {a[0]};
+  const int b[] = {a[0]};
+}