[PATCH] D49758: [clangd] allow clients to pass in compilationDatabaseChanges in the 'workspace/didChangeConfiguration' request

[Alex Lorenz via Phabricator via cfe-commits]

arphaman added inline comments.


================
Comment at: clangd/Protocol.h:429
+  // The changes that happened to the compilation database.
+  llvm::Optional<std::map<std::string, std::vector<std::string>>>
+      compilationDatabaseChanges;
----------------
ilya-biryukov wrote:
> - Maybe add a comment that the key of the map is a file name?
> - The value does not contain the working directory at the time, but we need that for building `tooling::CompileCommand`, maybe add it?
Could you please elaborate on the issue with the working directory? I didn't quite get that concern, sorry.


Repository:
  rCTE Clang Tools Extra

https://reviews.llvm.org/D49758