[PATCH] D49899: Make test/Driver/fuchsia.c(pp) work with lld or gold

David Greene via Phabricator via cfe-commits cfe-commits at lists.llvm.org
Thu Jul 26 19:15:54 PDT 2018


greened created this revision.
greened added reviewers: phosek, rsmith.
Herald added subscribers: cfe-commits, dexonsmith, mehdi_amini.

These tests don't appear to depend on lld.  They are invoking lto, so we should ensure the linker is capable of that.  Therefore, allow gold in addition to lld but nothing else.


Repository:
  rC Clang

https://reviews.llvm.org/D49899

Files:
  test/Driver/fuchsia.c
  test/Driver/fuchsia.cpp


Index: test/Driver/fuchsia.cpp
===================================================================
--- test/Driver/fuchsia.cpp
+++ test/Driver/fuchsia.cpp
@@ -6,7 +6,7 @@
 // CHECK: "-isysroot" "[[SYSROOT:[^"]+]]"
 // CHECK: "-internal-isystem" "{{.*[/\\]}}include{{/|\\\\}}c++{{/|\\\\}}v1"
 // CHECK: "-internal-externc-isystem" "[[SYSROOT]]{{/|\\\\}}include"
-// CHECK: {{.*}}ld.lld{{.*}}" "-z" "rodynamic"
+// CHECK: {{.*}}ld.{{(lld[^"]*" "-z" "rodynamic"|gold[^"]*")}}
 // CHECK: "--sysroot=[[SYSROOT]]"
 // CHECK: "-pie"
 // CHECK: "--build-id"
Index: test/Driver/fuchsia.c
===================================================================
--- test/Driver/fuchsia.c
+++ test/Driver/fuchsia.c
@@ -15,7 +15,7 @@
 // CHECK: "-fsanitize=safe-stack"
 // CHECK: "-stack-protector" "2"
 // CHECK: "-fno-common"
-// CHECK: {{.*}}ld.lld{{.*}}" "-z" "rodynamic"
+// CHECK: {{.*}}ld.{{(lld[^"]*" "-z" "rodynamic"|gold[^"]*")}}
 // CHECK: "--sysroot=[[SYSROOT]]"
 // CHECK: "-pie"
 // CHECK: "--build-id"


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D49899.157632.patch
Type: text/x-patch
Size: 1000 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180727/1b1cca73/attachment.bin>


More information about the cfe-commits mailing list