[clang-tools-extra] r338017 - [clangd] Proof-of-concept query iterators for Dex symbol index

[Jeremy Morse via cfe-commits]

 [Resending with cfe-commits@, whoops]

Hi Kirill,

We believe this patch might be breaking one of the buildbots:

    http://lab.llvm.org:8011/builders/clang-x86_64-linux-
abi-test/builds/29719

Which is complaining about the std::unique_ptr copy constructor being
called in DexIndexTests.cpp. It seems likely that returning a unique_ptr:

> std::unique_ptr<Iterator>
> createAnd(std::vector<std::unique_ptr<Iterator>> Children) {
>   return llvm::make_unique<AndIterator>(move(Children));
> }

And sites such as:

>  auto AndEmpty = createAnd({create(L0)});

Are triggering a bug in clang 3.7 and 3.8 where the move constructor isn't
correctly inferred:

    https://godbolt.org/g/Aquug4

Wrapping everything in std::move will likely fix that, those two versions
of clang are still officially supported by LLVM/Clang.

--
Thanks,
Jeremy
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/cfe-commits/attachments/20180726/3004a20a/attachment.html>