[PATCH] D49793: [AArch64] - return address signing

[Javed Absar via Phabricator via cfe-commits]

javed.absar added a comment.

Maybe you can provide some more context to this patch (why you need this, or point to some document), if possible.



================
Comment at: include/clang/Frontend/CodeGenOptions.h:111
 
+  enum SignReturnAddressScope { None, Partial, All };
+
----------------
Please conform this to the code around (i.e. each option on a separate line with comments explaining the option).


================
Comment at: test/CodeGen/aarch64-sign-return-address.c:5
+
+// NONE: @foo() #[[ATTR:[0-9]*]]
+// NONE-NOT: attributes #[[ATTR]] = { {{.*}} "sign-return-address"={{.*}} }
----------------
Can the label check not be under one 'CHECK' prefix? 


Repository:
  rC Clang

https://reviews.llvm.org/D49793